Skip to content

add send_filler_answers feature flag#2728

Merged
alice-carr merged 1 commit intomainfrom
add-send-filler-answers-feature-flag
Apr 28, 2026
Merged

add send_filler_answers feature flag#2728
alice-carr merged 1 commit intomainfrom
add-send-filler-answers-feature-flag

Conversation

@alice-carr
Copy link
Copy Markdown
Contributor

@alice-carr alice-carr commented Apr 27, 2026

What problem does this pull request solve?

added the feature flag to enable or disable sending a filler's answers to them. This is a feature flag for the whole environment rather than a group level flag.

This feature flag isn't being used to toggle functionality yet, this is in advance of the implementation of sending the filler's answers.

Trello card: https://trello.com/c/lr2stOI0/2905-create-new-feature-flag-in-admin-for-send-fillers-answers-feature

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@alice-carr alice-carr force-pushed the add-send-filler-answers-feature-flag branch 3 times, most recently from 99145c9 to 7b83639 Compare April 27, 2026 16:00
@alice-carr alice-carr marked this pull request as ready for review April 27, 2026 16:07
Comment thread config/settings.yml
@alice-carr alice-carr force-pushed the add-send-filler-answers-feature-flag branch from 7b83639 to df7b394 Compare April 28, 2026 10:19
@alice-carr alice-carr force-pushed the add-send-filler-answers-feature-flag branch from df7b394 to 710e15d Compare April 28, 2026 12:03
added the feature flag to enable or disable sending a filler's answers to them. This is a feature flag for the whole environment rather than a group level flag.

This feature flag isn't being used to toggle functionality yet, this is in advance of the implementation of sending the filler's answers.
@alice-carr alice-carr force-pushed the add-send-filler-answers-feature-flag branch from 710e15d to e2bce39 Compare April 28, 2026 12:05
@github-actions
Copy link
Copy Markdown

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2728.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@alice-carr alice-carr added this pull request to the merge queue Apr 28, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 28, 2026
@alice-carr alice-carr added this pull request to the merge queue Apr 28, 2026
Merged via the queue into main with commit a52e31a Apr 28, 2026
4 checks passed
@alice-carr alice-carr deleted the add-send-filler-answers-feature-flag branch April 28, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants